Then Elkanah and all his house went up to make the annual sacrifice to the LORD and to fulfill his vow,
Here is, I. The return of Elkanah and his family to their own habitation, when the days appointed for the feast were over, Sa1 1:19. Observe how they improved their time at the tabernacle. Every day they were there, even that which was fixed for their journey home, they worshipped God; and they rose up early to do it. It is good to begin the day with God.
Commenting on 1 Samuel 1:19-28
And the man Elkanah, and all his house,.... All his family, excepting Hannah, and her son Samuel; or all the men of his house, as the Targum; for only the males were obliged to appear at the three festivals: went up to Shiloh; to the house of God there: to offer unto the Lord the yearly sacrifice; either the passover, to which men commonly went...
the man Elkanah . . . went up to offer . . . his vow--The solemn expression of his concurrence in Hannah's vow was necessary to make it obligatory. (See on Num 30:3).